html editor

Hey Ray

Have just found an issue with the html editor when trying to update or insert a page and the validation fails. If you have added contemt to it, on fail it adds that content plus the tags <p></p> from this http://prntscr.com/o9fhfj to this http://prntscr.com/o9fhqg

It doesnt happen on insert or updates that dont fail

Cheers

Jamie

I think this is something you can control in the html editor settings. Please send your site definition file. I'm on vacation with my laptop, so I can't access your site, but I'll take a look once I have FTP access.

see PM

and no rush on my part mate...enjoy your holiday :)

So the issue is with the setting in your file: webassist/ckeditor/config.js

You have:
config.enterMode = CKEDITOR.ENTER_P;

You can see the options for that setting here:
https://ckeditor.com/docs/ckeditor4/latest/features/enterkey.html

If you use:
config.enterMode = CKEDITOR.ENTER_BR;

Then it will not add an empty P tag, but they don't recommend it since technically all content needs a tag in order to be styled. (you can't add a class or style attribute if you don't have a wrapping tag).

I've also read that you can add the tags:
config.fillEmptyBlocks = false;
config.autoParagraph = false;
config.ignoreEmptyParagraph = true;

Those may also work to address the issue... you would have to play with it to see which one(s) work.

A final option is that you could account for empty P tags on the top of the page in the php code like:

if (isset($_POST["FieldName"]) && $_POST["FieldName"]=="<p></p>") $_POST["FieldName"]="";

Hey Ray

Am not sure I understand as the issue isnt with empty <p> tags - on validation fail, existing text gets wrapped in a <p> tag in the html window (not in the 'source' window)

This has only recently started happening

If you have enter mode set to P, then it always wraps all text in a P tag. We default the config file to use BR instead for this reason. That will fix your problem.

config.autoParagraph = false;

may also address this issue if you don't want to change the enter mode.

Hey Ray

Thing is I can show you previous installations (using the same ckeditor code/files) that dont do this at all on validation. It leaves the text unchanged whilst still highlighting the element that failed validation (heres a screenshot of one http://prntscr.com/oe1r1m

I'll have to debug these in a screen sharing session to compare and figure out what the difference is. It has to be different files or config settings somehow.