Delete file not working

For some reason, I can't get the delete file function to work. It was originally a part of the wizard. It wasn't working so I tried reinstalling it. I have multiple deletes. But it doesn't work with just one either. Do you see anything obvious in the file I'm missing?

You have a delete redirect after you delete the row in the database and the delete file code is below that. Just move the delete row from table code (lines 11-22) below the delete files code (ending at line 61), and I think that will fix it.

Man I thought we had it. I had tried reordering before and kept running into errors, but i think it was because i moved the delete function before the query. I ordered just as you suggested. No errors, but it still doesn't want to delete the files.

Updated file attached.

I see now that you are deleting images using a row from the main recordset, but that recordset isn't filtered based on the record being deleted. That means the images from the first row are being deleted, not necessarily the images from the row you are deleting.

Maybe add a second recordset to the page specifically to get the row being deleted. Filter it with the value: <?php echo($_POST["WADADeleteRecordID"]); ?>

Then use that recordset to reference the images that need to be deleted. (and sorry this means the first row of your recordset had the images from it deleted already in your testing most likely)

Forgive my ignorance but I can't quite figure out how to code that query:


<?php
$rsDeleteFile = new WA_MySQLi_RS("rsDeleteFile",$framework_connect,1);
$rsDeleteFile->setQuery("SELECT id, `file` FROM tbl_images WHERE id = ?");
$rsDeleteFile->bindParam("i", "".($_POST["WADADeleteRecordID"]) ."", "-1"); //colname
$rsDeleteFile->execute();
?>

Also, wouldn't this have to come after the delete function so the WADADeleteRecordID would be defined, but then that would be after the redirect.

I went back and looked at one of my previous projects that was done under the old mySQL function rather than mySQLi, and in the past we didn't have to do a separate query. Is it mySQLi that causes us to have to do it differently?

The WADADeleteRecordID is from the POST (a hidden form element), so no it doesn't have to be after the delete function.

The query you have appears to be correct to me.

The WADADeleteRecordID is from the POST (a hidden form element), so no it doesn't have to be after the delete function.

The query you have appears to be correct to me.

I thought so too but it throws this error when I load the page:

Undefined index: WADADeleteRecordID in /Applications/XAMPP/xamppfiles/htdocs/sites/abm-sites/team-construction/sitecontrol/tbl_images_results.php on line 42
SiteControl by Advent Design

This line:

$rsDeleteFile->bindParam("i", "".($_POST["WADADeleteRecordID"]) ."", "-1"); //colname

should be:

$rsDeleteFile->bindParam("i", "".(isset($_POST["WADADeleteRecordID"])?$_POST["WADADeleteRecordID"]:"") ."", "-1"); //colname

since the form post value won't exist until after the form has posted.