XSS Scripting

Hey Ray

Have been contacted by someone from 'open bug bounty' - have looked into them and they seem legit? - but they have said that a site I have (in the PM) has a xss vuklnerability. They havent provided more details than that at this time.

Just wanted to ask if this was to do with the the action="<?php echo (htmlentities($_SERVER["PHP_SELF"], ENT_QUOTES)); ?>" in the contact form element and not requiring it filled in?

Or is it something else?

Cheers

Jamie

Remove the action tag or set it to action="". That should fix it.

Thanks very much. Is it only a contact form that I need to be looking at?

I would do a site-wide search for:
$_SERVER["PHP_SELF"]

and:
$_SERVER["QUERY_STRING"]

and make sure they aren't in an echo statement in the html anywhere.

thanks Ray

couple of follow up questions on this

1. is replacing $_SERVER["PHP_SELF"] with $_SERVER["REQUEST_URI"] ok?

2. is this ok as <form id="form1" name="form1" method="post" action="users_login.php?failed=1<?php echo(isset($_SERVER["QUERY_STRING"])?"&".($_SERVER["QUERY_STRING"]):""); ?>" class="form-container formLogin">?

No. That will cause issues too. Even REQUEST_URI is dangerous. The form action should be changed to action="" if it posts to the same page it is on.

ok thanks. another follow up is that I have navigation (attached) that uses a combination of both to select the on state depending on the page you're on - am I going to need to change this and how would I dynamically select the page/onstate ?

That doesn't need to be updated. You can check those values and use them in IF statements without issue. The issue occurs when they are written into the html, and that isn't done in this file.

thanks for all your help on this. Have had a follow up, details in PM

It looks like there is a typo in the file: webassist/form_validations/wavt_validatedform_php.php

if ($encoded) htmlspecialchars($retVal);

should be:

if ($encoded) $retVal = htmlspecialchars($retVal);

I'll get it corrected in the next update.