close ad
 
Important WebAssist Announcement
open ad
View Menu

Technical Support Forums

Free, outstanding support from WebAssist and your colleagues

rating

XSS issue: scan result says the scripts are vulnerable but cannot tell where

Thread began 11/10/2017 2:53 am by rikaG_510 | Last modified 11/27/2017 11:45 am by Ray Borduin | 966 views | 4 replies |

rikaG_510

XSS issue: scan result says the scripts are vulnerable but cannot tell where

Hi,

My UK site (www.rowingcentre.co.uk) is managed by 123-REG hosting company.
Recently the site has been hacked twice. I manually managed to delete the suspicious files for the first hack but the second time I reinstalled the whole site with clean files, then bought this ‘XSS scan’ provided by the host which detect the vulnerable scripts.

Attached image is the scan result but I have no clue what parts are vulnerable.
There are two files and I used WA’s app for both of them to build so hopefully you can tell what is wrong?

At the moment there’s no error and everything is fully functional.

Thank you for your help in advance.

Rika

Sign in to reply to this post

Ray BorduinWebAssist

This is because you are displaying form values on the page directly like this:
<?php echo((isset($_POST["Full_Name"]))?$_POST["Full_Name"]:"") ?>

Users could put some code other than their Full_Name when they fill out the form and then the code would run on the page. You may actually be preventing this with server side validation, but there is no way for your testing software to know that.

You can fix these errors by using:

php:
<?php echo((isset($_POST["Full_Name"]))?htmlspecialchars($_POST["Full_Name"]):""?>



the htmlspecialchars() function would encode anything that would allow cross site scripting.

The bad news is that this isn't how someone uploaded malicious files and hacked you. XSS allows users to get sensitive data from your customers like cookies but it isn't the type of vulnerably that opens the door to a full hack. This is worth correcting on the pages, but won't solve your larger issue.

Sign in to reply to this post
Did this help? Tips are appreciated...

rikaG_510

Hi Ray,

Thank you. I will fix the code as you suggested.
For the larger issues, my host provides the daily scan to detect any suspicious action through FTP, so not worried so much for the time being.
But certainly I will learn more about XSS :)

Rika

Sign in to reply to this post

rikaG_510

Hi Ray,

I fixed the parts you spotted in the way you suggested. One file is marked as safe, but the other one (attached) is still vulnerable.
I did make changes where I could, but I don't know what else is needed to be done. Could you kindly advise me, please?

Thank you for you help.
Rika

Sign in to reply to this post

Ray BorduinWebAssist

The same issue on lines 420, 424 and lines 491-503

All of them meed htmlspecialcharacters() added like you have on the other lines.

Sign in to reply to this post
Did this help? Tips are appreciated...

Build websites with a little help from your friends

Your friends over here at WebAssist! These Dreamweaver extensions will assist you in building unlimited, custom websites.

Build websites from already-built web applications

These out-of-the-box solutions provide you proven, tested applications that can be up and running now.  Build a store, a gallery, or a web-based email solution.

Want your website pre-built and hosted?

Close Windowclose

Rate your experience or provide feedback on this page

Account or customer service questions?
Please user our contact form.

Need technical support?
Please visit support to ask a question

Content

rating

Layout

rating

Ease of use

rating

security code refresh image

We do not respond to comments submitted from this page directly, but we do read and analyze any feedback and will use it to help make your experience better in the future.

Close Windowclose

We were unable to retrieve the attached file

Close Windowclose

Attach and remove files

add attachmentAdd attachment
Close Windowclose

Enter the URL you would like to link to in your post

Close Windowclose

This is how you use right click RTF editing

Enable right click RTF editing option allows you to add html markup into your tutorial such as images, bulleted lists, files and more...

-- click to close --

Uploading file...