Search not filtering after I add additional "Where" clause in the recordset

1/04/2015 8:10 pm | #1 Blikbrein

I have a page with payments and charges that is filtered by begin date and end date. I do not want to show any zero values in the filtered report and therefor I have added a Where in the recordset:

WHERE PaymentDebit > 0 OR PaymentCredit > 0

Without the 'OR PaymentCredit > 0' Date filtering works but after adding it all records are shown and there is no filtering.

I've attached the page for you to inspect. The result must be that records are filtered according to begin and end date and that items with a 0 in PaymentDebit AND 0 in PaymentCredit should not be shown which would be a 0 value record.

Attached Files

Transaction_results.php

1/07/2015 12:34 am | #3 Blikbrein

Thanks but in this case OR is needed since all debits have 0 credit values and all Credits have 0 debit values which means every entry will have either a 0 in the debit field or a 0 in the credit field. No record wil have a debit AND credit > 0. This needs to be OR, but as I said the Search behaviour then shows all the records in the query instead of filtering them.

1/07/2015 7:50 am | #4 Jason ByrnesWebAssist

The recordset code is duplicated.

change lines 135 - 164:

<?php
$maxRows_WADAPayments = 1000;
$pageNum_WADAPayments = 0;
if (isset($_GET['pageNum_WADAPayments'])) {
  $pageNum_WADAPayments = $_GET['pageNum_WADAPayments'];
}
$startRow_WADAPayments = $pageNum_WADAPayments * $maxRows_WADAPayments;

mysql_select_db($database_anna, $anna);
$query_WADAPayments = "SELECT PaymentsID, `Users`.`UserFirstName` AS Users_UserFirstName, Users.UserSurname, `ContractTracking`.`PackageID` AS ContractTracking_PackageID, PaymentDate, PaymentDocno, PaymentDebit, PaymentCredit FROM Payments LEFT JOIN Users ON Users.UserID = Payments.PaymentClientID LEFT JOIN ContractTracking ON ContractTracking.ContractID = Payments.PaymentContractTrackingID WHERE PaymentDebit > 0 OR PaymentCredit > 0 ORDER BY Users.UserSurname ASC, `Users`.`UserFirstName` ASC, PaymentDate ASC";
setQueryBuilderSource($query_WADAPayments,$WADbSearch1,false);
$query_limit_WADAPayments = sprintf("%s LIMIT %d, %d", $query_WADAPayments, $startRow_WADAPayments, $maxRows_WADAPayments);
$WADAPayments = mysql_query($query_limit_WADAPayments, $anna) or die(mysql_error());
$row_WADAPayments = mysql_fetch_assoc($WADAPayments);

if (isset($_GET['totalRows_WADAPayments'])) {
  $totalRows_WADAPayments = $_GET['totalRows_WADAPayments'];
} else {
  $all_WADAPayments = mysql_query($query_WADAPayments, $anna);
  $totalRows_WADAPayments = mysql_num_rows($all_WADAPayments);
}
$totalPages_WADAPayments = ceil($totalRows_WADAPayments/$maxRows_WADAPayments)-1;

mysql_select_db($database_anna, $anna);
$query_WADATotals = "SELECT SUM(PaymentDebit) AS Debits, SUM(PaymentCredit) AS Credits, SUM(PaymentDebit) - SUM(PaymentCredit) as Balance FROM Payments LEFT JOIN Users ON Users.UserID = Payments.PaymentClientID LEFT JOIN ContractTracking ON ContractTracking.ContractID = Payments.PaymentContractTrackingID";
setQueryBuilderSource($query_WADATotals,$WADbSearch2,false);
$WADATotals = mysql_query($query_WADATotals, $anna) or die(mysql_error());
$row_WADATotals = mysql_fetch_assoc($WADATotals);
$totalRows_WADATotals = mysql_num_rows($WADATotals);
?>

to:

<?php
$maxRows_WADAPayments = 1000;
$pageNum_WADAPayments = 0;
if (isset($_GET['pageNum_WADAPayments'])) {
  $pageNum_WADAPayments = $_GET['pageNum_WADAPayments'];
}
$startRow_WADAPayments = $pageNum_WADAPayments * $maxRows_WADAPayments;

mysql_select_db($database_anna, $anna);
$query_WADAPayments = "SELECT PaymentsID, `Users`.`UserFirstName` AS Users_UserFirstName, Users.UserSurname, `ContractTracking`.`PackageID` AS ContractTracking_PackageID, PaymentDate, PaymentDocno, PaymentDebit, PaymentCredit FROM Payments LEFT JOIN Users ON Users.UserID = Payments.PaymentClientID LEFT JOIN ContractTracking ON ContractTracking.ContractID = Payments.PaymentContractTrackingID WHERE PaymentDebit > 0 OR PaymentCredit > 0 ORDER BY Users.UserSurname ASC, `Users`.`UserFirstName` ASC, PaymentDate ASC";
setQueryBuilderSource($query_WADAPayments,$WADbSearch1,false);
$query_limit_WADAPayments = sprintf("%s LIMIT %d, %d", $query_WADAPayments, $startRow_WADAPayments, $maxRows_WADAPayments);
$WADAPayments = mysql_query($query_limit_WADAPayments, $anna) or die(mysql_error());
$row_WADAPayments = mysql_fetch_assoc($WADAPayments);

if (isset($_GET['totalRows_WADAPayments'])) {
  $totalRows_WADAPayments = $_GET['totalRows_WADAPayments'];
} else {
  $all_WADAPayments = mysql_query($query_WADAPayments, $anna);
  $totalRows_WADAPayments = mysql_num_rows($all_WADAPayments);
}
$totalPages_WADAPayments = ceil($totalRows_WADAPayments/$maxRows_WADAPayments)-1;
?>

NOTE: the recordset criteria you mention is contrary to what you originally wrote, that is the basis for the confusion.

and that items with a 0 in PaymentDebit AND 0 in PaymentCredit should not be shown

that is why I suggested using AND.

1/07/2015 10:24 am | #5 Blikbrein

Ok, thanks. Apologies for the misunderstanding. Why does the recordset sometimes duplicate? Normally I see this and delete the duplication, but this time I missed it. I think it happens with complex queries...?

Will let you know if it worked after I deleted and retried.

1/07/2015 10:34 am | #6 Blikbrein

Tried it and still get all the records instead of filtered results... I attached the changed file for you to look at again. Thanks

Attached Files

Transaction_results.php

Technical Support Forums

Free, outstanding support from WebAssist and your colleagues

Search not filtering after I add additional "Where" clause in the recordset

1/04/2015 8:10 pm | #1 Blikbrein