Problem in Script ?

Please can you help - we have a script running very slowly suddenly. Our server people are telling me as below. I have just applied your script as usual . Please can you confirm


Hyve Support Ticket Amended - 10027: Mailing script problem back again


Hi

IPS is now enabled. Its blocking lots of malicous activity as you can see in the IPS Data button. It has also shown us a problem in one of the scripts

\andrewstaxis.com\httpdocs\Admin\ContactDrivers\index.php

while ($RecipIndex < sizeof($RecipArray)) {
$EnteredValue = is_string($RecipArray[$RecipIndex][0]);
$CurIndex = 0;
while (($EnteredValue && $CurIndex < sizeof($RecipArray[$RecipIndex])) || (!$EnteredValue && $RecipArray[$RecipIndex][0])) {
$starttime = microtime_float();
if ($EnteredValue) {
$RecipientEmail = $RecipArray[$RecipIndex][$CurIndex];
} else {
$RecipientEmail = $RecipArray[$RecipIndex][0][$RecipArray[$RecipIndex][2]];
}
$EmailsRemaining = ($TotalEmails- $LoopCount);
$BurstsRemaining = ceil(($EmailsRemaining-$AfterBursts)/$BurstSize);
$IntoBurst = ($EmailsRemaining-$AfterBursts) % $BurstSize;
if ($AfterBursts<$EmailsRemaining) $IntoBurst = 0;
$TimeRemaining = ($BurstsRemaining * $BurstTime * 60) + ((($AfterBursts<$EmailsRemaining)?$AfterBursts:$EmailsRemaining)*$RealWait) - (($AfterBursts>$EmailsRemaining)?0:($IntoBurst*$RealWait));
if ($TimeRemaining < ($EmailsRemaining*$RealWait) ) {
$TimeRemaining = $EmailsRemaining*$RealWait;
}
$CurIndex ++;
$LoopCount ++;
session_commit();
session_start();
$_SESSION[$EmailRef."_Index"] = $LoopCount;
$_SESSION[$EmailRef."_Remaining"] = round($TimeRemaining);
session_commit();
wa_sleep($WaitTime);
include("../../webassist/email/waue_index_1.php");
$endtime = microtime_float();
$TimeTracker[] =$endtime - $starttime;
$RealWait = array_sum($TimeTracker)/sizeof($TimeTracker);
if ($LoopCount % $BurstSize == 0 && $CurIndex < sizeof($RecipArray[$RecipIndex])) {
$TimePassed = (time() - $StartBurst);
if ($TimePassed < ($BurstTime*60)) {
$WaitBurst = ($BurstTime*60) -$TimePassed;
wa_sleep($WaitBurst);
}
else {
$TimeRemaining = ($TotalEmails- $LoopCount)*$RealWait;
}
$StartBurst = time();
}
if (!$EnteredValue) {
$RecipArray[$RecipIndex][0] = mysql_fetch_assoc($RecipArray[$RecipIndex][1]);
}
}
$RecipIndex ++;
}


The following lines of code

session_commit();
session_start();
$_SESSION[$EmailRef."_Index"] = $LoopCount;
$_SESSION[$EmailRef."_Remaining"] = round($TimeRemaining);
session_commit();

Basically webassist need to change session_commit(); and session_start(); should not be called this many times. They should not be inside the loop as its writing many header variables. Can these be changed to local variables and added after the loop.

Best regards,
Jon Lucas

Those lines of code are in place for error logging.

they set session variables that contain data about each individual email being sent to allow for tracking the email progress.

the session_start() function is in place to force php to look for the session, in some servers we have had problems with php not finding the session. session_commit() is in place to force PHP to write the session data, we have run into that problem in some cases as well.

If you are not tracking email progress, you can comment out those lines if you wish.

They have commented out the code on the script - and it is sending but doesnt complete. The server is struggling to send out 116 e mails

Can somebody there help to debug this without the need to send out mails as some drivers are receiving loads of them ( from the erarly part of the list ) but the list does not complete and divert to the confirmed page

Do you have code we can embed to show the mailout on screen without actually sending mails ?

Thanks

John

I have created a support ticket so we can look into this issue further.

To view and edit your support ticket, please log into your support history:
supporthistory.php

If anyone else is experiencing this same issue, please append to this thread.