Problem with Javascript code in template (Piwik)

Hi all,

I am not sure if this has been reported. I saw some similar issues, but they seemed to be slightly different.

I was trying to add Piwik (Web Analytics Code) to the template which has a line like this:

document.write(unescape("%3Cscript src='" + pkBaseURL + "piwik.js' type='text/javascript'%3E%3C/script%3E"));

That line was being re-written, apparently by framework, to:

document.write(unescape("%3Cscript src='Templates' + pkBaseURL + "piwik.js' type='text/javascript'%3E%3C/script%3E"));

I'm not entirely sure why, but this fixes the problem, however it concerns me as a bug that, if I am right about the cause, should be addressed.

This workaround fixes the problem.

document.write(unescape("%3Cscript sr"+"c='" + pkBaseURL + "piwik.js' type='text/javascript'%3E%3C/script%3E"));

This is being done by framework builder. The framework builder tries to update any src paths and it assumes the base path is relative to the file it is located in.

Your work around is valid. I'll log this as a bug to see if we can update the code to better recognize this type of script and not update the path in this case.

I don't think framework is the only template mechanism that would be affected by this. I'm not sure how you would better detect which src's to change without negatively impacting one that should be replaced and is not. As you know, I am more concerned that it detect links that are site root relative and not change those (ignore src="/dir/file.php").

I suppose another fix would be to put this code in an external file.

Thanks for looking into it.