I have the answer
OK, this is how I repro the bug.
Install ALL of the WebAssist extensions that come with the WebAssist Extension Library program.
Create a new site and follow all the instructions for installing the User Registration Solution Pack. Install the db and all the files and edit your globals and connection files so the site operates as intended and is all new with no other edits.
You will notice that the user email validation server behavior works as intended and the Helper_PHP.php file in the SecurityAssist folder of your site is the same as the one that came in the zip file.
Create a new php template with an editable region for content and save it as a template. Do NOT apply the template to anything. There is no need to apply it to see the bug.
Now create a div in the body of the template above your editable region. I created the following code.
<div id="divRegMenu">
<table width="955" border="0" cellpadding="0" cellspacing="0">
<tr>
<td align="right">This will be the registration menu links.</td>
</tr>
</table>
</div>
Save all.
Select the code and go to your server behaviors panel.
Add the "SecurityAssist => Show Region" behavior and set the rule to "Logged In to Users".
Save all.
That's it. Check the Helper_PHP.php page and you will see that it has been changed to the new one that does not work.
My guess is that either the Security Assist extension has a bug in it's code where the helper page is overwritten with the wrong code, or the User Registration Solution Pack is being shipped with the wrong code and the rules file should not have the check for both the user id and the email verification.
Using features of the SecurityAssist extension cause the bug in the User Registration Solution Pack. This prevents me from using that extension if I want the User Registration Solution Pack to work correctly on my site. I want to continue using the SecurityAssist extension on the site after installing the User Registration Solution Pack so I need a fix for this.
I have SecurityAssist version "1.1.8" installed.
Please get back to me as soon as you can as my site cannot go live until I can get a fix for this issue one way or the other.