No, but it is complex so it could be a matter of having the correct parenthesis. Maybe use a switch statement instead like:
<?php
switch ($People->getColumnVal("StaffType")) {
case 0:
echo "Barrister";
break;
case 1:
echo "Pupil";
break;
case 2:
echo "Clerk";
break;
default:
echo "Admin";
}
?>