CSS Form Builder non re-entrant or partly buggy ?

Hi,

Wondering why my form won't work anymore after editing and i found that the extension will create new variables names based on labels choosen, without removing old code or warning you.

So i get this king of duplicate code :

<?php
if ($_SERVER["REQUEST_METHOD"] == "POST") {
$WAFV_Redirect = "contact.php";
$_SESSION['WAVT_contact2_Errors'] = "";
if ($WAFV_Redirect == "") {
$WAFV_Redirect = $_SERVER["PHP_SELF"];
}
$WAFV_Errors = "";
$WAFV_Errors .= WAValidateRQ((isset($_POST["Contact_me_group_Name"])?$_POST["Contact_me_group_Name"]:"") . "",true,1);
$WAFV_Errors .= WAValidateEM((isset($_POST["Contact_me_group_Email"])?$_POST["Contact_me_group_Email"]:"") . "",true,2);
$WAFV_Errors .= WAValidateLE((strtolower(isset($_POST["Contact_me_group_Security_code"])?$_POST["Contact_me_group_Security_code"]:"")) . "",((isset($_SESSION["captcha_Contact_me_group_Security_code"]))?strtolower($_SESSION["captcha_Contact_me_group_Security_code"]):"") . "",true,3);
$WAFV_Errors .= WAValidateRX((isset($_POST["HiddenFields_fields"])?$_POST["HiddenFields_fields"]:"") . "","/.*/",false,5);

if ($WAFV_Errors != "") {
PostResult($WAFV_Redirect,$WAFV_Errors,"contact2");
}
}
?>
<?php
if (isset($_POST["SimpleContact_submit_x"]) && !isset($_GET["invalid"])) {
$WAFV_Redirect = "contact.php";
$_SESSION['WAVT_contact2_Errors'] = "";
if ($WAFV_Redirect == "") {
$WAFV_Redirect = $_SERVER["PHP_SELF"];
}
$WAFV_Errors = "";
$WAFV_Errors .= WAValidateRQ((isset($_POST["Contact_me_group_Nom"])?$_POST["Contact_me_group_Nom"]:"") . "",true,1);
$WAFV_Errors .= WAValidateEM((isset($_POST["Contact_me_group_Email"])?$_POST["Contact_me_group_Email"]:"") . "",true,2);
$WAFV_Errors .= WAValidateRQ((isset($_POST["Contact_me_group_Message"])?$_POST["Contact_me_group_Message"]:"") . "",true,3);
$WAFV_Errors .= WAValidateLE((strtolower(isset($_POST["Contact_me_group_Code_Securite"])?$_POST["Contact_me_group_Code_Securite"]:"")) . "",((isset($_SESSION["captcha_Contact_me_group_Code_Securite"]))?strtolower($_SESSION["captcha_Contact_me_group_Code_Securite"]):"") . "",true,4);
$WAFV_Errors .= WAValidateRX((isset($_POST["HiddenFields_fields"])?$_POST["HiddenFields_fields"]:"") . "","/.*/",false,5);

if ($WAFV_Errors != "") {
PostResult($WAFV_Redirect,$WAFV_Errors,"contact2");
}
}
?>

Regards

Though technically non re-entrant... since any updates you make after application will not be recognized... it should still remove and replace any form and not create duplicate code like this, so this sounds like a bug, but it depends on your process.

To edit the form, make sure to click the edit button after highlighting the form in the properties inspector window. If you simply highlight and reapply over the old form it would not properly replace all of the other parts of the code, so that may be what happened in this case.

I will report it to the QA team to log as a bug and investigate a solution.

Here is a screen shot detailing step 1 and 2. This is where i clic, first, on the blue frame, and the on the edit buttons.

Hope this is usefull.

Regards

Laurent

Thanks for the follow up. It appears it is a bug. You can of course delete the repeated code for now, but we will work on getting this problem reproduced and fixed. Just so we are on the same page, what version of form builder do you have installed?

Would you mind attaching a copy of your page before the duplicate code was inserted so we can try to reproduce it?

Thank you

I have version 1.0.1. I am afraid i don't have it anymore, but i will try to reproduce a new one for you an update you ASAP

Awesome. Thank you very much

You will find attached in the zip, 4 files :

Before re-applying CSS Form Builder (2 files) :
---------------------------------------------
contact-bug.php submits to contact2-bug.php and works fine.

Notice sometimes on Firefox 3.6.3 Vista 64 there is strange things happening. A kind of variable persistance ; a get the message "Please enter a full email address" when reloading the page, having all fields empty, and other strange thing. I don't remember exactly but i know i had to completely close Firefox to have work correctly. Do you know how some cookie or session pb in this version of FF 3 ?


After re-applying CSS Form Builder and changing some labels (2 files) :
-------------------------------------------------------------------
contact-bug-after.php submits to contact2-bug-after.php and doesn't work any more because of duplicate code.

I also notice this difference between the begining of the 2 blocs of codes :
if ($_SERVER["REQUEST_METHOD"] == "POST") (-->herited from first step/file)
and
if (isset($_POST["SimpleContact_submit_x"]) && !isset($_GET["invalid"])) { (-->new code)

Regards

Laurent